You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In preparation for adding the custom LA footer content in this ticket, this PR sets us up to more easily customize the footer.
It also removes the pattern we have in the core generic footer of having a string intentionally split onto multiple rows as that is not accessibility best practice. We also are now underlining links in the text content (we don't need to in the links footer).
How Can This Be Tested/Reviewed?
When (I suppose if) we bring this over to Detroit we will need to update this file over there, but it will be p easy.
You can check out the deploy preview vs dev (there is less content now).
Author Checklist:
Added QA notes to the issue with applicable URLs
Reviewed in a desktop view
Reviewed in a mobile view
Reviewed considering accessibility
Added tests covering the changes
Made corresponding changes to the documentation
Ran yarn generate:client and/or created a migration when required
Review Process:
Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Can you document somewhere the several changes we have made recently including this one that will require changes in Detroit if we ever start pulling code over again? That way if that day comes we have one place to look for all of these small breaking changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready to mergeShould be applied when a PR has been reviewed and approved
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for adding the custom LA footer content in this ticket, this PR sets us up to more easily customize the footer.
It also removes the pattern we have in the core generic footer of having a string intentionally split onto multiple rows as that is not accessibility best practice. We also are now underlining links in the text content (we don't need to in the links footer).
How Can This Be Tested/Reviewed?
When (I suppose if) we bring this over to Detroit we will need to update this file over there, but it will be p easy.
You can check out the deploy preview vs dev (there is less content now).
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: